fix: notes is (nothing) not working #3998
Conversation
actual-github-bot
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged No assets were unchanged |
UnderKoen
force-pushed
the
UnderKoen/fix/notes-is-nothing
branch
from
ceee85f to
247d79e
Compare
UnderKoen
changed the title
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
packages/loot-core/src/server/accounts/rules.test.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-eslint-plugin". (The package "eslint-plugin-eslint-plugin" was not found when loaded as a Node module from the directory "/packages/eslint-plugin-actual".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-eslint-plugin" was referenced from the config file in "packages/eslint-plugin-actual/.eslintrc.js". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThis pull request introduces modifications to the condition evaluation logic in the In the Correspondingly, in the These modifications enhance the flexibility and error handling of the condition evaluation process without changing the overall structure or signatures of the existing code. Possibly related PRs
Suggested labels
Suggested reviewers
Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/loot-core/src/server/accounts/rules.test.ts (1)
51-52: Consider adding a more descriptive test case name.While the test correctly verifies the fix, it would be clearer if it was in its own test case with a descriptive name that explains the expected behavior.
- cond = new Condition('is', 'notes', '', null); - expect(cond.eval({ notes: null })).toBe(true); + test('empty string notes condition matches null notes field', () => { + const cond = new Condition('is', 'notes', '', null); + expect(cond.eval({ notes: null })).toBe(true); + });
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
upcoming-release-notes/3998.mdis excluded by!**/*.md
📒 Files selected for processing (2)
packages/loot-core/src/server/accounts/rules.test.ts(1 hunks)packages/loot-core/src/server/accounts/rules.ts(1 hunks)
🔇 Additional comments (1)
packages/loot-core/src/server/accounts/rules.ts (1)
363-367: LGTM! Improved string field handling.
The addition of null coalescing for string fields ensures consistent behavior when evaluating conditions against null or undefined values. This is a good practice for string handling.
|
The only change Im seeing is that this causes the notes to be filled as soon as you tab over to the notes field. Edge currently will run the rule right but it wont fill until after you have tabbed past the notes field. Is there something else that Im missing? |
If you never set the notes field the rule will never trigger. When is was testing #3805 for why it wasn't working this also became apparent. Because it also never triggerd. I haven't tested the import flow as my bank always fill the notes field. |
Testing:
create the following rule
create a new transaction, and set the payee
the notes should be set.